Fixed broken display of mail in Google Mail web client #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is the issue that Sorry, the inline CSS makes it awkward to diff. |
|
+1 I was expecting this to work with all major email clients. Didn't really display well in gmail. You should mention that in the README file. |
|
Works fine for me on gmail using this: https://github.com/FDIM/node-html-email-example (same template + juice) |
|
Made several improvements and release 1.0.0 Please let me know if these improvements addressed the issues you were having. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Becaue of #37 I created a working solution for Google Mail web client. This was not thoroughly tested with all E-Mail providers out there so please do your own testing!
Environment: Google Mail web client with Firefox 45 and Google Chrome Version 50.0.2661.18 dev (64-bit) both on OSX 10.11.3.