Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

memory_limit should not be interpreted as an integer. #165

Closed
Jean-Daniel opened this issue Aug 31, 2022 · 1 comment
Closed

memory_limit should not be interpreted as an integer. #165

Jean-Daniel opened this issue Aug 31, 2022 · 1 comment

Comments

@Jean-Daniel
Copy link

Jean-Daniel commented Aug 31, 2022

When using php FPM, the memory limit defaults to 128M causing the following warning on the login page:

Your php memory limit is low - currently 128M, you should increase it to atleast 24. This is normally controlled in /etc/php.ini

php ldap admin should either stop trying to tell me what the good limit should be, or properly interpret the php memory limit setting instead of assuming the limit is an integer representing the number of bytes.

@williamdes
Copy link

This is what I added in my Dockerfile to remove the check

    # See: https://github.com/leenooks/phpLDAPadmin/issues/165
    sed -i -e "/Check the memory limit parameter/,+6d" lib/functions.php && \
    php -l lib/functions.php

lvlte added a commit to lvlte/phpLDAPadmin that referenced this issue Feb 3, 2023
leenooks pushed a commit that referenced this issue Feb 15, 2023
* fix #165 : Handle shorthand notation for PHP memory_limit check

* fix config default memory threshold.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants