-
-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional performance benchmarks #1
Comments
will do!
it uses it already [1]. i based it on one of the boost examples, but maybe more param tweaking [2] can make it faster. i didn't spend additional time trying to figure it out. feel free to contribute any improvements! [1] https://github.com/leeoniya/uPlot/blob/master/bench/Highcharts.html#L14 |
added ZingChart based on [1], i'll add the interaction metric later (need to tweak config to display live values and hovered datapoints), but i don't expect any surprises. it should be noted that the article makes reference to an evenly-spaced-data optimization and the bench dataset is mostly evenly spaced since the sampling interval in cron was 1m (but it could be +/- 1s in final timestamps). however, uPlot's performance does not depend on the data being evenly spaced whatsoever, so i chose not to use this "optimization" in the bench. if you're curious how that version performed: 1310ms render, 1500ms total, 96.8 MB mem. [1] https://blog.zingchart.com/charts-with-time-series-data/ |
That's great! Thanks so much for adding the additional benchmarks! I'm going to send some improvements to the Chart.js benchmark later. How do you do the timings? Do you just look in the Chrome developer tools performance tab? Or should I just send the improvements and let you update the timings? |
nice, looking forward to it!
I try to do a few runs and force garbage collection between them to get the most representative/fair numbers. It's not terribly scientific, but with such large deltas between libs it doesn't really need to be.
i'm sure you'll be interested in the timings on your own machine relative to some baseline. but obviously i'll re-run them on the same machine as the others either way. [1] https://github.com/leeoniya/uPlot/blob/master/bench/uPlot.html#L124 |
ZingChart utilizes canvas, so would be interesting to add to the benchmark.
Also, I noticed Highcharts was listed. I think it'd be interesting benchmark it with the boost module as well.
The text was updated successfully, but these errors were encountered: