added initial types

[fluxin]

No description provided.

[leeoniya]

hey @fluxin,

any idea how to get VScode to pick up the types in a test.js file? do i need a jsconfig.json [1]?

how would VScode associate types/index.d.ts with e.g. /dist/uPlot.esm.js or /src/uPlot.js.

also, the lib constructor is uPlot, not UPlot as in this PR, is that an issue?

[1] https://code.visualstudio.com/docs/languages/jsconfig

[leeoniya]

ok, i finally got it working by sticking the file into /dist/uPlot.esm.d.ts and creating a jsconfig.json with "compilerOptions": {"checkJs": true} and adding "typings": "./dist/uPlot.esm.d.ts" to package.json

[leeoniya]

i've it merged this locally and it's working well. i'm making a lot of additions and some changes, so it'll be another day or two before i push everything up. i might have some more questions later, but everything is straightforward so far.

[fluxin]

Sorry for the lack of responding at a customer's this week

…

On Thu, Mar 19, 2020, 2:49 PM Leon Sorokin ***@***.***> wrote: i've it merged this locally and it's working well. i'm making a lot of additions and some changes, so it'll be another day or two before i push everything up. i might have some more questions later, but everything is straightforward so far. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#153 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAAWBLPMJLWOR5HUS4IHK3RIJZLPANCNFSM4LJ33YDQ> .

[leeoniya]

Sorry for the lack of responding at a customer's this week

no worries :) this PR is exactly the type of scaffold i was needing. you did a great job of covering the majority of the necessary nuances - it must have taken some time to crawl through the docs, demos and source to put it together, so thanks.

i've added single-line jsdoc comments to pretty much everything i've reviewed and corrected so far. i also made a couple minor API refinements along the way.

i'm about 70% done at 353 LOC. what's left to review/finish is:

• Axis
• Grid
• Ticks
• Scale
• Hooks

i'll finish it up this weekend and maybe you, @leolabs, @photonstorm, @danyalejandro can take a look afterwards for tweaks/issues before i tag a new version.

[fluxin]

Great to hear!

…

On Fri, Mar 20, 2020, 9:06 PM Leon Sorokin ***@***.***> wrote: Merged #153 <#153> into master. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#153 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAAWBJG7ZE6TAWF64Z7ZLTRIQOI5ANCNFSM4LJ33YDQ> .