Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug in margins() with glmerMod objects (#129) #43

Merged
merged 1 commit into from Jun 20, 2020
Merged

Fix a bug in margins() with glmerMod objects (#129) #43

merged 1 commit into from Jun 20, 2020

Conversation

vincentarelbundock
Copy link
Contributor

Please ensure the following before submitting a PR:

  • if suggesting code changes or improvements, open an issue first
  • for all but trivial changes (e.g., typo fixes), add your name to DESCRIPTION
  • for all but trivial changes (e.g., typo fixes), documentation your change in NEWS.md with a parenthetical reference to the issue number being addressed
  • make sure R CMD check runs without error before submitting the PR

In combination with my concurrent PR at leeper/margins this fixes Issue #129 of margins.

Here, I am simply improving find_data.merMod. I have written no new code for this. I just copied over the find_data.default method, and modified the model[['class']] by model@class, because glmerMod is a S4.

@leeper leeper merged commit f0787f6 into leeper:master Jun 20, 2020
@leeper
Copy link
Owner

leeper commented Jun 20, 2020

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants