Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added biography and more details to people #422

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Conversation

JVT038
Copy link
Collaborator

@JVT038 JVT038 commented Jul 4, 2023

Could you check out the mobile layout? I don't really like it, but don't know how to improve it.

Current person page on wider screens:

image

Current person page on smaller screens:
image

@JVT038 JVT038 requested a review from leepeuker as a code owner July 4, 2023 15:21
@JVT038 JVT038 linked an issue Jul 4, 2023 that may be closed by this pull request
@leepeuker
Copy link
Owner

image

The person image should be closer to the content on the right. The distance changes with the screen sizes, it should be a fixed distance between the image and the content on all sizes

@JVT038
Copy link
Collaborator Author

JVT038 commented Jul 25, 2023

It currently looks like this:

image

The distance / margins between the image and the biography don't change anymore.

@leepeuker
Copy link
Owner

leepeuker commented Jul 27, 2023

image

The distance / margins between the image and the biography is good now. But there is empty space at the right site and to much at the left site

Compare it for example with a movie page, where this starts at the left site vs here

@leepeuker
Copy link
Owner

The show more button looks off too I think

image

And I would prefer if we lose the circle, this does not feel matching to the rest 🤔

@leepeuker
Copy link
Owner

image

Oh and I noticed a longer text (Place of birth) on the right site moves the left site further away. I think the distance should be static and exactly match the picture, the text should break

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make cast pages more detailed
2 participants