Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all content to a CMS (Sanity.io) #496

Merged
merged 12 commits into from Jun 19, 2022
Merged

Move all content to a CMS (Sanity.io) #496

merged 12 commits into from Jun 19, 2022

Conversation

leerob
Copy link
Owner

@leerob leerob commented Jun 19, 2022

Since many people fork this repository, I'd like to prevent them from including all of my blog posts and personal information. This PR moves everything from my data/* folder to Sanity, which gives me a number of benefits:

  • Faster git clone times due to less files and images
  • Easier forking for folks looking to use this repo as a template
  • Ability to update content without redeploying

This is using the new v3 of Sanity: https://www.sanity.io/blog/sanity-studio-v3-developer-preview

@vercel
Copy link

vercel bot commented Jun 19, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
leerob ✅ Ready (Inspect) Visit Preview Jun 19, 2022 at 11:53PM (UTC)

@leerob
Copy link
Owner Author

leerob commented Jun 19, 2022

TODO

@leerob leerob mentioned this pull request Jun 19, 2022
@leerob leerob marked this pull request as ready for review June 19, 2022 23:40
@leerob
Copy link
Owner Author

leerob commented Jun 19, 2022

Think I'm gonna fix Preview Mode in a follow-up PR. Worth merging now!

@nvh95
Copy link

nvh95 commented Jun 21, 2022

@leerob I think moving content to a CMS blocks people from directly proposing changes to your posts by sending a PR. I guess they have to submit a new issue instead of sending a PR (or worse, don't even propose changes).

If the goal is to prevent people from including blog posts we can consider git submodule (or similar solution), where you can put all your data in a separate repository. People can still submit PR (typo/ translations...) to your posts as well. (The idea is to separate code and content to 2 different repositories)

These are just my naive thoughts when reading your PR. I know there are trade-offs when deciding where to put content data (CMS/ mdx).

@leerob
Copy link
Owner Author

leerob commented Jun 21, 2022

There's more benefits that just that, namely that I can update content without redeploying 😄

https://on-demand-isr.vercel.app/

@trm217
Copy link

trm217 commented Jun 22, 2022

@leerob Why did you disable the usage of preact in production?

@leerob
Copy link
Owner Author

leerob commented Jun 24, 2022

There's currently a bug it seems where the meta tags in the head like title and description weren't working.

@Music47ell
Copy link

There's currently a bug it seems where the meta tags in the head like title and description weren't working.

I've been struggling with this issue for the past week. I undid all the changes I made, tried different versions of packages I'm using. Nothing worked.

Just now, I decided to get rid of preact because I noticed you're not using it and the meta tags in my site started to work again.

Little bit of searching in this repository, and I just stumbled upon this 🤦‍♂️😂

ajaymoturi12 pushed a commit to ajaymoturi12/personal-site that referenced this pull request Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants