-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggest: no use of attach in examples #10
Comments
Contacted the SKAT maintainer by email: Dear SKAT maintainer, I contact you as I have posted two Issues at the SKAT GitHub repo and am unsure if you have read these. If you have and just haven't had the time yet, I would understand :-) Looking forward to a response one day and cheers, Richel Bilderbeek |
Thanks for the suggestion. I modified the example |
BTW, adding column name isn't done yet. It will be great if you can do this. |
Dear SKAT authors, thanks for writing this package! I do have a minor suggestion and I do volunteer to submit a Pull Request , which I describe below.
When viewing the SKAT::SKAT doc ...
we find this example code:
I suggest to avoid the use of attach in this example, as lintr, the Tidyverse coding standard, states that attach is an undesirable function.
The easy solution would be to write the same code as such:
In this way, the examples depend less on the state of
env
.Could you agree that following the most used R coding standard is a good idea? Again, I do volunteer to do so :-)
The text was updated successfully, but these errors were encountered: