Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: -target option to CMAKE_C_FLAGS for xcframework and -simulator t… #117

Closed
wants to merge 1 commit into from

Conversation

AJenbo
Copy link

@AJenbo AJenbo commented Dec 1, 2021

Creating this to trigger CI for #114

@AJenbo
Copy link
Author

AJenbo commented Dec 1, 2021

@leetal has TravisCI died for you as well?

@leetal
Copy link
Owner

leetal commented Dec 1, 2021

Yes. I'll start paying for it to allow the builds to continue :) fixing tomorrow!

@AJenbo
Copy link
Author

AJenbo commented Dec 2, 2021

You could also just migrate to GitHub Action, here is an example of how we run test on macOS: https://github.com/diasurgical/devilutionX/blob/master/.github/workflows/MacOSX.yml

@leetal
Copy link
Owner

leetal commented Dec 12, 2021

Hi! Sorry for taking so much time on this, but if you could just merge this with master upstream, the builds would now run on Github Actions instead of TravisCI :) Thanks for the tip and actually making me migrate!

@AJenbo
Copy link
Author

AJenbo commented Dec 12, 2021

Alright now you just need to verify that I'm not a bitcoin miner :)

@leetal
Copy link
Owner

leetal commented Dec 12, 2021

Haha just "Github things" ;) Approved and running 👍

@leetal
Copy link
Owner

leetal commented Dec 12, 2021

I wonder if the fixes i just now implemented for another bug (#116) here #121 might fix the watchos bugs seen here? The triple created previously in the toolchain was not following apples own target triples created by xcode

@AJenbo
Copy link
Author

AJenbo commented Dec 12, 2021

Hm I probably won't be looking in to it since it doesn't affect my use case. But I can do some simple things like rebasing evey now and then if it would be helpful

leetal pushed a commit that referenced this pull request Jan 9, 2022
@leetal leetal closed this in dcdadf2 Jan 9, 2022
leetal added a commit that referenced this pull request Jan 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants