Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#include <cstring> for memset/memcpy #14

Closed
sagamusix opened this issue Sep 9, 2016 · 3 comments
Closed

#include <cstring> for memset/memcpy #14

sagamusix opened this issue Sep 9, 2016 · 3 comments

Comments

@sagamusix
Copy link
Contributor

micropather.h contains some function implementations which reference memset and memcpy, which are defined in <cstring>. This header is not included, so it is currently up to the library user to include it, whether they need it or not. The header should be included in micropather.h or the function implementations should be moved to micropather.cpp.
@leethomason
Copy link
Owner

Any chance you could post a PR?

@sagamusix
Copy link
Contributor Author

For the simple inclusion of <cstring> I could do that, but I didn't do so far since I wanted to hear your opinion on moving those functions to micropather.cpp instead.

@leethomason
Copy link
Owner

Oops, sorry, dropped the thread. Probably better to move it to the cpp and include it from there.

leethomason added a commit that referenced this issue Oct 17, 2016
@leethomason
Merge pull request #16 from sagamusix/master
33a3b84 
Fix #14 by no longer inlining functions in header file; <cstring> is no longer required to be included by the user.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@leethomason @sagamusix