You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've noticed that while inside XMLNode::FirstChildElement() & XMLNode::LastChildElement() functions
at the string matching level you're using the Name() function of XMLElement (and so a conversion with ToElement()),
inside XMLNode::NextSiblingElement() & XMLNode::PreviousSiblingElement() you're using the Value() function of XMLNode directly. Indeed, Name() function of XMLElement is just a call to Value() function of XMLNode and Value() is not a virtual functions, that is a potential overrideable function.
What do you think?
could we assume Value() instead of Name() inside XMLNode::FirstChildElement() & XMLNode::LastChildElement() avoiding the ToElement() function call?
Let me know if it is unclear,
Thanks
The text was updated successfully, but these errors were encountered:
Hi,
I've noticed that while inside XMLNode::FirstChildElement() & XMLNode::LastChildElement() functions
at the string matching level you're using the Name() function of XMLElement (and so a conversion with ToElement()),
inside XMLNode::NextSiblingElement() & XMLNode::PreviousSiblingElement() you're using the Value() function of XMLNode directly. Indeed, Name() function of XMLElement is just a call to Value() function of XMLNode and Value() is not a virtual functions, that is a potential overrideable function.
What do you think?
could we assume Value() instead of Name() inside XMLNode::FirstChildElement() & XMLNode::LastChildElement() avoiding the ToElement() function call?
Let me know if it is unclear,
Thanks
The text was updated successfully, but these errors were encountered: