Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake: Refactor targets export variable and improve comments #789

Merged
merged 4 commits into from Sep 17, 2020
Merged

cmake: Refactor targets export variable and improve comments #789

merged 4 commits into from Sep 17, 2020

Commits on Dec 3, 2019

  1. cmake: Use CMAKE_PROJECT_NAME instead of PROJECT_NAME 

    This is consistent with other usages of the file.
PROJECT_NAME is only useful if there are subprojects, and there
aren't any here.
    @offlinemark
    offlinemark committed Dec 3, 2019
    Configuration menu
    Copy the full SHA
    e86e947 View commit details
    Browse the repository at this point in the history

  2. cmake: Use TARGETS_EXPORT_NAME var throughout file 

    Previously, it was totally unused.
    @offlinemark
    offlinemark committed Dec 3, 2019
    Configuration menu
    Copy the full SHA
    57cd52b View commit details
    Browse the repository at this point in the history

  3. cmake: Clarify comment around exported cmake script 

    The `export()` command purely exports a cmake script into the build
directory; it is not related to find_package at all. It is technically
not necessary. The main use case would be a user copying it into their
internal cmake/ dir in their project, and then using `include()`'ing
that file in their cmake.

The `install(EXPORT...` command is what actually generates a cmake
module that is put on the filesystem in a location that can be found by
`find_package` when in config mode.
    @offlinemark
    offlinemark committed Dec 3, 2019
    Configuration menu
    Copy the full SHA
    588c657 View commit details
    Browse the repository at this point in the history

  4. cmake: Move TARGETS_EXPORT_NAME to top

    @offlinemark
    offlinemark committed Dec 3, 2019
    Configuration menu
    Copy the full SHA
    60e9616 View commit details
    Browse the repository at this point in the history