standartize example package's target names #406
Conversation
|
This relates to #364. The names in the issue description does not have the |
examples/simple-scene/Cargo.toml
Outdated
|
|
||
| [[bin]] | ||
| name = "hotham_simple_scene_example" | ||
| name = "hotham_simple_scene_example_desktop" |
There was a problem hiding this comment.
The suggested name in the issue description #364 is simple_scene_desktop.
There was a problem hiding this comment.
fixed in this commit
upd. but now it breaks common naming style which has hotham_ prefix. maybe it would be better to stick to packages naming style: complex-scene-example, crab-saber, etc, which does not contain hotham_ prefix then? let's wait for Kane to answer the question above
There was a problem hiding this comment.
I think the hotham_ prefix is the way to go! Sorry, I'll clarify that in the issue. 😄
There was a problem hiding this comment.
I think the
hotham_prefix is the way to go! Sorry, I'll clarify that in the issue. 😄
curious, what's the thinking behind the prefix? feels more ergonomic to me to have it as simple_scene_example_desktop
|
Thanks so much for taking care of this, Nikolay! I’m just a bit swamped
this week, but will come back to it properly shortly. :-)
…On Thu, 10 Nov 2022 at 6:13 am, Nikolay ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In examples/simple-scene/Cargo.toml
<#406 (comment)>:
>
[[bin]]
-name = "hotham_simple_scene_example"
+name = "hotham_simple_scene_example_desktop"
fixed in this commit
<2498d02>
—
Reply to this email directly, view it on GitHub
<#406 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAPNXZ6XRMKOVP2UXK7Q6V3WHPZU5ANCNFSM6AAAAAAR3XKF6Y>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
No description provided.