Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create TensorForce PR for manually closing agent/model #1

Closed
lefnire opened this issue Jan 19, 2018 · 1 comment
Closed

Create TensorForce PR for manually closing agent/model #1

lefnire opened this issue Jan 19, 2018 · 1 comment
Projects

Comments

@lefnire
Copy link
Owner

lefnire commented Jan 19, 2018

Create a PR to TensorForce adding this commit, which manually removes auto-closing agent/model w/in runner.py so that we can work with the model a bit after training (to test, to use in live-mode, etc) - we'll close manually.

Above commit is insufficient. Will need to change all their code instances currently using runner.py and adding agent.close();model.close() after runner.run(). This is the only commit in my fork required for this project, so getting that into upstream will remove my fork as a dep.

@lefnire lefnire added this to To Do in Main Jan 20, 2018
@lefnire lefnire closed this as completed Jan 21, 2018
@lefnire
Copy link
Owner Author

lefnire commented Jan 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Main
  
To Do
Development

No branches or pull requests

1 participant