Runner requires manual call to close() so calling-code can work with "dirty" runner #310
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A conversation I'd had earlier with @AlexKuhnle - in order to do cross-validation, or alternating train/test, we came to doing this:
With the current TensorForce code, the Test segment will fail because agent & model will have been closed automatically (in the end of
runner.run()
). For consideration: this PR which requires manually closingrunner
, or possibly a method argument such asauto_close=True
.