Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds mkdirp which is a missing dependency. #2

Closed
wants to merge 1 commit into from
Closed

Adds mkdirp which is a missing dependency. #2

wants to merge 1 commit into from

Conversation

davidgomes
Copy link

When I tried to use the library for the first time I got this error:

Error: Cannot find module 'mkdirp'
    at Function.Module._resolveFilename (module.js:336:15)
    at Function.Module._load (module.js:286:25)
    at Module.require (module.js:365:17)
    at require (module.js:384:17)
    at Object.<anonymous> (/Users/david/src/pentagine.js/node_modules/unminified-webpack-plugin/index.js:6:14)
    at Module._compile (module.js:434:26)
    at Module._extensions..js (module.js:452:10)
    at require.extensions.(anonymous function) (/Users/david/src/pentagine.js/node_modules/babel-core/node_modules/babel-register/lib/node.js:166:7)
    at Object.require.extensions.(anonymous function) [as .js] (/usr/local/lib/node_modules/babel/lib/babel/api/register/node.js:113:7)
    at Module.load (module.js:355:32)

As so, I think you should add mkdirp as a dev dependency.

@davidgomes
Copy link
Author

If you think this should be a regular dependency and not a dev-dependency, let me know and I'll fix it 😄

leftstick added a commit that referenced this pull request Jun 24, 2016
@leftstick
Copy link
Owner

It's some unused code there, just removed. Thanks for reporting this issue.

@leftstick leftstick closed this Jun 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants