Replace the last occurrence of 'min' in instead of the first #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…first Previously, if you used any of the words in this list http://www.morewords.com/contains/min/ to name your bundle (say, for example, `minimal.min.js`) then this plugin would strip the first min resulting in a file named `imal.min.js` which makes no sense. This change switches the `min` replacement to look for the last occurrence of min instead of the first, since that is the more common naming convention for minified files.
|
It's really good PR, thanks @pcardune |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if you used any of the words in this list
http://www.morewords.com/contains/min/ to name your bundle (for
example,
minimal.min.js) then this plugin would strip the first minresulting in a file named
imal.min.jswhich makes no sense.This change switches the
minreplacement to look for the lastoccurrence of min instead of the first, since that is the more common
naming convention for minified files.