Extra line breaks after coloured lines in detail view

[evilquinn]

Hey, excellent extension, thanks.

In my client, there appeared to be extra line breaks in the detail output.

Here's raw output on a terminal:

And here's a view of the detail output for the same commit:

Snapshot of the raw html:

[evilquinn]

think it's down to an extra \n being added during colouring of changed lines here:

vscode-gitk/src/services/gitLogResolver.ts

Lines 77 to 78 in d466cc8

	.replace(/^(-[^\n]*)/mg, m => `<span style="color: #ff2441;">${m.replace(/\n$/, '')}</span>\n`)
	.replace(/^(\+[^\n]*)/mg, m => `<span style="color: #00c02b;">${m.replace(/\n$/, '')}</span>\n`)

[evilquinn]

question: is this a feature? and not a defect?

I ask because this appears to have been the case since the first commit here, and the demo gif in the readme shows these extra breaks...

[leftstick]

Hi @evilquinn thanks for your questions, i don't think it is a feature.
@geforcesong would you please check it? Thanks

[evilquinn]

fixed by #11
thanks!

[leftstick]

@evilquinn already published to martketplace, thanks for your awesome work

[evilquinn]

unbelievable!
great stuff everyone, thank you!.

(if of interest, my first ever pull-request to someone else's github project! feels good)