Fix the 32 bit builds by changing a type cast #1202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`i64::from` was replaced by a direct `as` type cast. Tested on i686-unknown-linux-gnu
mautamu
added a commit
to mautamu/leftwm
that referenced
this pull request
Jan 1, 2024
mautamu
added a commit
that referenced
this pull request
Jan 8, 2024
* chore: clippy fixes * fix: override clippy lint #1202 * chore: add comment [no ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
i64::fromwas replaced by a directastype cast. to fix the 32bit build error expressed in the issue below.I don't expect this change to cause any problems as we are casting a smaller type (u32) into a larger one (c_long should be i64-eqivalent).
Compilation was tested on i686-unknown-linux-gnu toolchain.
Fixes #1201
Type of change
Checklist:
make testlocally with no errors or warnings reportedNote: To fully reproduce CI checks, you will need to run
make test-full-nix. Usually, this is not necessary.