Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create feature parity of command pipe #794

Merged
merged 5 commits into from
Aug 2, 2022

Conversation

VuiMuich
Copy link
Member

Description

As brought up on the discord some commands where missing in the command pipe and therefore also in leftwm-command.
It was intended to solve this in #682, but as that got delayed I suggest pulling this patch ahead.

In the review of said PR we had discussed the idea of reordering by categories, so here goes my suggestion for it.
As this ordering is purly a cosmetic change to help with future addition of commands and keeping track, whats there, it can easily be redone if it is not liked.
But if we like it, I suggest to procede to refactor all other occurences of the complete set of commands in the same order, to help navigating the code.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Updated user documentation:

No user doc update required.

Checklist:

  • Ran make test-full locally with no errors or warnings reported
  • Manual page has been updated accordingly
  • Wiki pages have been updated accordingly (to perform after merge)

@VuiMuich VuiMuich requested a review from AethanFoot July 26, 2022 11:38
Copy link
Member

@AethanFoot AethanFoot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good!

@VuiMuich VuiMuich merged commit b2e9860 into leftwm:main Aug 2, 2022
@VuiMuich VuiMuich deleted the command_pipe_parity branch August 2, 2022 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants