fix: allocator restarting unnecessarily (#666)

Fixes an issue whereby everytime a job runs the allocator service would restart.
leg100 · Dec 10, 2023 · 47f8e6f · 47f8e6f
1 parent e196837
commit 47f8e6f
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/internal/agent/allocator.go b/internal/agent/allocator.go
@@ -151,7 +151,8 @@ func (a *allocator) allocate(ctx context.Context) error {
 			a.agents[*job.AgentID].CurrentJobs--
 			continue
 		default:
-			return fmt.Errorf("unknown job status: %s", job.Status)
+			// job running; ignore
+			continue
 		}
 		// allocate job to available agent
 		var available []*Agent

diff --git a/internal/agent/allocator_test.go b/internal/agent/allocator_test.go
@@ -166,6 +166,14 @@ func TestAllocator_allocate(t *testing.T) {
 			wantJob:    nil,
 			wantAgents: map[string]*Agent{"agent-1": {ID: "agent-1", CurrentJobs: 0}},
 		},
+		{
+			name: "ignore running job",
+			job: &Job{
+				Spec:    JobSpec{RunID: "run-123", Phase: internal.PlanPhase},
+				Status:  JobRunning,
+				AgentID: internal.String("agent-1"),
+			},
+		},
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {