chore: chromium bug fixed (#559)

chromedp/chromedp#1325 (comment)
leg100 · Aug 5, 2023 · 87af2c7 · 87af2c7
1 parent 3dd465a
commit 87af2c7
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 13 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -27,12 +27,6 @@ jobs:
         run: make vet
       - name: API tests
         run: make go-tfe-tests
-        # chromium breaks browser-based tests:
-        # https://github.com/chromedp/chromedp/issues/1325#issuecomment-1606114185
-      - name: Remove chromium
-        run: |
-          sudo rm /usr/bin/chromium
-          sudo rm /usr/bin/chromium-browser
       - name: Tests
         env:
           GOOGLE_CREDENTIALS: ${{ secrets.GOOGLE_CREDENTIALS }}

diff --git a/internal/integration/main_test.go b/internal/integration/main_test.go
@@ -5,7 +5,6 @@ import (
 	"crypto/rand"
 	"fmt"
 	"os"
-	"os/exec"
 	"path"
 	"path/filepath"
 	"testing"
@@ -44,12 +43,6 @@ func TestMain(m *testing.M) {
 }
 
 func doMain(m *testing.M) (int, error) {
-	for _, chromium := range []string{"chromium", "chromium-browser"} {
-		if _, err := exec.LookPath(chromium); err == nil {
-			return 0, fmt.Errorf("found %s executable in path; chromium has a bug that breaks the browser-based tests; see https://github.com/chromedp/chromedp/issues/1325", chromium)
-		}
-	}
-
 	// Start external services
 	if err := testcompose.Up(); err != nil {
 		return 0, fmt.Errorf("starting external services: %w", err)