fix: delete webhooks when org or vcs provider is deleted #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leg100
pushed a commit
that referenced
this pull request
Jul 12, 2023
🤖 I have created a release *beep* *boop* --- ## [0.0.53](v0.0.52...v0.0.53) (2023-07-12) ### Bug Fixes * delete existing unreferenced webhooks too ([6b61b48](6b61b48)) * delete webhooks when org or vcs provider is deleted ([#518](#518)) ([0d36ea5](0d36ea5)) * **docs:** version using tag not branch name ([8613fe8](8613fe8)) * only set not null after populating column ([1da3936](1da3936)) * remove trailing slash from requests ([#516](#516)) ([c1ee39e](c1ee39e)), closes [#496](#496) * **ui:** add cache-control header to static files ([061261f](061261f)) ### Miscellaneous * add hashes to all static urls ([3650926](3650926)) * test create connected workspace via api ([9bf4bae](9bf4bae)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #504
Fixes #506
Refactors webhook deletion to leverage postgres' cascade functionality. Doing so means deleting parent resources (organizations, vcs providers) also deletes webhooks. The deletion triggers the "webhook purger", which deletes webhooks from the VCS repo provider.