Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: wizard minimum height to avoid hidden elements #147

Merged
merged 3 commits into from
Oct 20, 2020
Merged

fix: wizard minimum height to avoid hidden elements #147

merged 3 commits into from
Oct 20, 2020

Conversation

re2005
Copy link
Contributor

@re2005 re2005 commented Jul 28, 2020

@re2005 re2005 requested a review from jasny July 28, 2020 09:37
jasny
jasny requested changes Jul 28, 2020
View reviewed changes
Copy link
Member

@jasny jasny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has min-width instead of min-height.
Can you use % or vh?

jasny
jasny requested changes Jul 31, 2020
View reviewed changes
css/general.css Outdated Show resolved Hide resolved
@re2005
refactor: remove overflow hidden
6b84cfa 
Since all children wrapping elements have already overflow hidden it may be not necessary.
@jasny jasny merged commit b3c301a into master Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasny jasny jasny requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@re2005 @jasny