Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle GSM network errors by default (+CMS ERROR:) #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

svogl
Copy link

@svogl svogl commented Aug 19, 2019

while testing with a gsm module that was not booked into a network, the modemService was blocked on startup as +CMS errors were not handled.
adding +CMS ERROR: to the patterns of possible return values fixes this.

while testing with a gsm module that was not booked into a network, the modemService was blocked on startup as +CMS errors were not handled.
adding +CMS ERROR: to the patterns of possible return values fixes this.
@CoRfr
Copy link
Contributor

CoRfr commented Aug 19, 2019

Hi @svogl and thanks for your contribution!

Change looks good to me, but before we accept it, can you sign the contribution agreement: https://github.com/legatoproject/legato-af/blob/master/CONTRIB_INDIVIDUAL.md ? (https://github.com/legatoproject/legato-af/blob/master/CONTRIB_COMPANY.md for a company)

Thanks!

@CoRfr CoRfr added the bug label Aug 19, 2019
@svogl
Copy link
Author

svogl commented Aug 20, 2019

... on its way.

@CoRfr
Copy link
Contributor

CoRfr commented Jun 11, 2020

Hi @svogl , we didn't seem to have received the agreement, did you sent it to legal@legato.io ?

@svogl
Copy link
Author

svogl commented Jun 12, 2020 via email

@CoRfr
Copy link
Contributor

CoRfr commented Jun 12, 2020 via email

@CoRfr CoRfr added the cla-ok label Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants