Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the latest legend-pydataobj version #37

Merged
merged 3 commits into from
Jan 1, 2024
Merged

Conversation

gipert
Copy link
Member

@gipert gipert commented Jan 1, 2024

If tests pass, I would merge this and release a new alpha version (needed to update legend-daq2lh5 and pygama).

@gipert gipert added the dependencies Pull requests that update a dependency file label Jan 1, 2024
Copy link

codecov bot commented Jan 1, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (2c0d1c2) 60.85% compared to head (ca7f2ff) 60.83%.

❗ Current head ca7f2ff differs from pull request most recent head e57ced3. Consider uploading reports for the commit e57ced3 to get more accurate results

Files Patch % Lines
src/dspeed/processors/wiener_filter.py 33.33% 2 Missing ⚠️
src/dspeed/build_dsp.py 66.66% 1 Missing ⚠️
src/dspeed/processing_chain.py 66.66% 1 Missing ⚠️
src/dspeed/vis/waveform_browser.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #37      +/-   ##
==========================================
- Coverage   60.85%   60.83%   -0.03%     
==========================================
  Files          46       46              
  Lines        2915     2913       -2     
==========================================
- Hits         1774     1772       -2     
  Misses       1141     1141              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gipert gipert merged commit 5f5bf78 into main Jan 1, 2024
1 of 2 checks passed
@gipert gipert deleted the pydataobj-update branch January 1, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant