Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review Language: Finnish (Python) #170

Open
5 of 11 tasks
madiedgar opened this issue Oct 29, 2020 · 8 comments
Open
5 of 11 tasks

Review Language: Finnish (Python) #170

madiedgar opened this issue Oct 29, 2020 · 8 comments

Comments

@madiedgar
Copy link
Member

madiedgar commented Oct 29, 2020

Review Finnish Translations for Python

In order to review this language to the project, complete the steps detailed in the translation guide (from Step #6 onward). We are primarily working developing Legesher for the Python programming language. In the future we hope to add more programming languages in the future.

Reviewing a translation is extremely important as we want to best understand the culture and context behind the words we select as keywords for the programming languages. The more perspectives the better! 👀Please take your time in being thorough with these translations. Think back when you were learning how to program and how context of words help you bridge together meaning and functionality.

⚠️ Note: this issue is to review the Python keywords and builtin functions only. Any additional translation reviews are encouraged, but not necessary.

To complete this issue:

  • Update any content in this issue from LANGUAGE to the name of the language. (Romanian, Arabic, Welsh etc.)

  • Title this issue "Review Language: Finnish (Python)"

  • Update the Python section of the Finnish's locale/__.yml file (files are named using the language abbreviation) by adding comments as followed.

    • Agreeable: Leave a # @username ✅_with any additional commentary afterwards_ after a translation if you agree that the right word to give context to the keyword is the one initially translated.
    • Optimistic: Leave a # @username ❓_with any additional commentary afterwards_ after a translation if you think there may be a better translation / form of the translation
    • Unsure: Leave a # @username 🤔_with any additional commentary afterwards_ after a word that you're not sure if there is a translation

    This issue will be complete when all the words for a programming language looks something like this:

    int: "initiatorsTranslation" # ✅ @firstreviewer, ❓@secondreviewer what about this otherTranslation, ❓@thirdreviewer I agree with otherTranslation, ✅ @fourthreviewer, ✅ @fifthreviewer I also think otherTranslation would be a good option
  • Merge changes into branch titled finnish-translation on this repo, NOT the master branch. Please reference this issue in the pull request.

Reviewers Needed

In order to add the translations for official use across Legesher, the translations will need to be approved and accepted by 5 additional native / fluent speakers. If you would like to be one of the reviewers for this language, please mention in this issue! 😄 Also feel free to loop in a friend that might be able to help with the translations! Please refer to the translation guide for the next step in the review process.

Review Status:

@sjarva
Copy link

sjarva commented Nov 8, 2020

I'd love to review this! I'm also calling @minna-xD and @eevajonnapanula, would you like to and have time to review Finnish translations? 😄

@minna-xD
Copy link

minna-xD commented Nov 8, 2020

Yes, I can help with this!

@madiedgar
Copy link
Member Author

Awesome! Thank you @sjarva and @minna-xD, let me know if you have any questions along the way!

@minna-xD
Copy link

minna-xD commented Nov 9, 2020

This is a silly question but I wasn't able to find out the answer by looking at the existing contributions:
You say "Leave a # @username ✅_with any additional commentary afterwards_" but then the sample line is:
int: "initiatorsTranslation" # ✅ @firstreviewer, ❓@secondreviewer what about this otherTranslation
I suppose there's really no difference as long as it's clear enough but is there a preference? Which should come first? The icon noting the status or the reviewer name?

@madiedgar
Copy link
Member Author

@minna-xD not a silly question at all! Rather it's a great catch👍🏾

As long as it is clear what review is yours, the order of elements in the review is entirely up to you. The order of reviewers is more important, as the reviewer order will be used if there is a word that needs to have further discussion.

@minna-xD
Copy link

The order of reviewers is more important

Good to know!

@minna-xD
Copy link

I'd love to review this! I'm also calling minna-xD and eevajonnapanula, would you like to and have time to review Finnish translations? 😄

Could we get some of our other LUK friends to join, do you think @sjarva?

@madiedgar
Copy link
Member Author

Happy October @minna-xD, @sjarva , and @rouskuli , thank you for your early support on this project! I'm excited about adding the Finnish translation to Legesher, but I could use your assistance in gathering enough reviewers. Would you consider reaching out to your friends or peers who share an interest and invite them to join us? 😄 Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants