Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python install setup #18

Merged
merged 2 commits into from Jun 16, 2022
Merged

Conversation

AlexReimann
Copy link
Contributor

  • Adds installs for config and launch folders
  • Makes module elevation_mapping_cupy out of python files in /scripts folder
    • Minor adjustments to elevation_mapping.py and elevation_mapping_wrapper.cpp to work with module
  • Adds setup.py and catkin_python_setup()

@AlexReimann
Copy link
Contributor Author

Fix for #16

mktk1117 pushed a commit that referenced this pull request Jun 16, 2022
add a smooth layer to be used as base reference
mktk1117 added a commit that referenced this pull request Jun 16, 2022
Pull requests from AlexReimann #18
- Adds installs for config and launch folders
- Makes module elevation_mapping_cupy out of python files in /scripts folder
- Minor adjustments to elevation_mapping.py and elevation_mapping_wrapper.cpp to work with module
- Adds setup.py and catkin_python_setup()
@mktk1117 mktk1117 merged commit 21075a0 into leggedrobotics:main Jun 16, 2022
@mktk1117
Copy link
Collaborator

Thanks Alex!

@AlexReimann AlexReimann deleted the python_install_setup branch June 16, 2022 20:53
@AlexReimann
Copy link
Contributor Author

One further remark:

For me the installed package python module was not by default found, because it gets installed into the lib/python3/ and the env PYTHONPATH only has ``lib/python2.7/ under ROS melodic.

This was fixed by adding <env name="PYTHONPATH" value="/opt/<your install dir>/lib/python3/dist-packages:$(env PYTHONPATH)" /> in the <node></node> tag of the launch file:

<launch>
  <node pkg="elevation_mapping_cupy" type="elevation_mapping_node" name="elevation_mapping">
    <env name="PYTHONPATH" value="/opt/<your install dir>/lib/python3/dist-packages:$(env PYTHONPATH)" />
  </node>
</launch>

Might want to add a note about this somewhere?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants