Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have functions like print_all from the library crate return strings to the caller instead of printing to stdout #24

Closed
leggettc18 opened this issue Jun 7, 2019 · 5 comments
Assignees
Milestone

Comments

@leggettc18
Copy link
Owner

In GitLab by @leggettc18 on Oct 7, 2018, 18:33

@leggettc18 leggettc18 added this to the 1.0.0 milestone Jun 7, 2019
@leggettc18 leggettc18 self-assigned this Jun 7, 2019
@leggettc18
Copy link
Owner Author

In GitLab by @leggettc18 on Oct 10, 2018, 17:44

Thinking about it, the library probably shouldn't be directly outputting data about itself to any strings at all. It provides enough functionality as part of the public API that the caller can get whatever data they want and format it however they want to. The current print statements are only really useful to CLI applications, for a GUI program it would make more sense for it to be able to get whatever information it needs in string form between the getter methods on FundManager, the display_dollars helper method, and the Display trait on Fund. For now I'm going to be relocating these functions out of the library into the binary crate, as they are pretty much just taking up space in the library crate.

@leggettc18
Copy link
Owner Author

In GitLab by @leggettc18 on Oct 10, 2018, 18:00

mentioned in commit 27083a3

@leggettc18
Copy link
Owner Author

In GitLab by @leggettc18 on Oct 10, 2018, 18:05

mentioned in merge request !20

@leggettc18
Copy link
Owner Author

In GitLab by @leggettc18 on Oct 10, 2018, 18:05

closed via merge request !20

@leggettc18
Copy link
Owner Author

In GitLab by @leggettc18 on Oct 10, 2018, 18:05

mentioned in commit 6c97628

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant