openSUSE upstreaming, part 1 #111
Conversation
|
I removed the questionable commits and drop or rework them. |
| @@ -42,6 +42,7 @@ keycode 9 = eight parenleft bracketleft | |||
| alt keycode 9 = Meta_eight | |||
| keycode 10 = nine parenright bracketright | |||
| alt keycode 10 = Meta_nine | |||
| control altgr keycode 10 = Control_bracketright | |||
There was a problem hiding this comment.
It's impossible to press [CTRL]+[]] with sv keyboard. Fix that.It's impossible to press [CTRL]+[]] with sv keyboard. Fix that.
It's not true.
$ git grep -w Control_bracketright data/keymaps/i386/qwerty/sv-latin1.map
data/keymaps/i386/qwerty/sv-latin1.map:32: control keycode 6 = Control_bracketright
data/keymaps/i386/qwerty/sv-latin1.map:61: control keycode 27 = Control_bracketright
There was a problem hiding this comment.
I still have this question. You add Control_bracketright and say that it is impossible to press it. But Control_bracketright is already in this keymap.
What does this patch fix?
There was a problem hiding this comment.
On the Swedish layout, both mapping are weird.
Key code 6 — 5, %
Key code 27 — ◌̈, ^, ~
Key code 27 seems to be chosen because the ISO layout (the UK, for example) has ] at this place. The reason for key code 6 is a mystery to me.
But none of them use the actual key ].
Control_bracketright should be mapped to Ctrl+], and for the Swedish layout ] is AltGr+9, so Control_bracketright should be mapped to Ctrl+AltGr+9. Therefore this change is valid, but it adds the 3rd way to press Control_bracketright.
There was a problem hiding this comment.
On the Swedish layout, both mapping are weird.
I used this to see the keyboard layout: http://kbdlayout.info/kbdsg and for Swiss German the ] is on key code 27 and only for German it is on key code 10.
Therefore this change is valid, but it adds the 3rd way to press Control_bracketright.
Ok. I'm going to take this commit, but it seems to me that the commit message does not correspond to the changes. Can we describe the changes more clearly?
There was a problem hiding this comment.
sv-latin1.map: make Ctrl+AltGr+9 act as Ctrl+]
As ] (bracketright) is emitted by AltGr+9, we should assign Ctrl+] (Control_bracketright) to Ctrl+AltGr+9.
| @@ -89,5 +89,4 @@ The \fI\-w\fR idea is from "sam". | |||
|
|
|||
| .SH "SEE ALSO" | |||
| .BR chvt (1), | |||
| .BR doshell (8), | |||
There was a problem hiding this comment.
It looks like out of all the remaining commits this is the only one that makes sense.
It's impossible to press [CTRL]+[]] with sv keyboard. Fix that. Signed-off-by: Stanislav Brabec <sbrabec@suse.cz>
openvt(1) refers to doshell(8) man page that does not exist anywhere. Remove it. Signed-off-by: Stanislav Brabec <sbrabec@suse.cz>
stanislav-brabec
force-pushed
the
master
branch
from
65e2c6d
to
aa9e707
Compare
These are a number of changes from openSUSE that Stanislav Brabec sent to the upstream. Link: #111 Signed-off-by: Alexey Gladkov <legion@kernel.org>
|
Applied. Thanks! |
Here is a first set of openSUSE patches. Feel free to cherry pick.