unimaps: add mapping for U+25CF #90
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix DCO check. - Switch to ubuntu-latest. - Switch to actions/checkout@v3. Signed-off-by: Alexey Gladkov <gladkov.alexey@gmail.com>
`systemctl status xxx.service` uses the U+25CF character. The unicode maps in font files like eurlatgr.psfu and cp850-8x16.psfu have an entry for U+25CF, but the plaintext unimap files do not. Fill this gap so that the use of raw .fnt (+map) files looks sensible. Signed-off-by: Jan Engelhardt <jengelh@inai.de>
legionus
added a commit
that referenced
this pull request
Apr 18, 2023
`systemctl status xxx.service` uses the U+25CF character. The unicode maps in font files like eurlatgr.psfu and cp850-8x16.psfu have an entry for U+25CF, but the plaintext unimap files do not. Fill this gap so that the use of raw .fnt (+map) files looks sensible. Signed-off-by: Jan Engelhardt <jengelh@inai.de> Link: #90 Signed-off-by: Alexey Gladkov <gladkov.alexey@gmail.com>
|
Looks good. Thanks! Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
systemctl status xxx.serviceuses the U+25CF BLACK CIRCLE character.The unicode maps in font files like eurlatgr.psfu and cp850-8x16.psfu have an entry for U+25CF, but the plaintext unimap files do not. Fill this gap so that the use of raw .fnt (+map) files looks sensible.
Note:
cp850-8x16 maps U+25CF to position 0x0A (white circle), while this patch proposes positioning U+25CF on 0x07 (black circle/big bullet). Either 0x07 or 0x0A would work, or should we edit the psfu files to switch to 0x07? I'm really indifferent to the detail…