Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

findDOMNode exploding with react 15 #20

Closed
gavmck opened this issue Mar 20, 2017 · 5 comments · Fixed by #22
Closed

findDOMNode exploding with react 15 #20

gavmck opened this issue Mar 20, 2017 · 5 comments · Fixed by #22

Comments

@gavmck
Copy link
Contributor

gavmck commented Mar 20, 2017

Getting

Uncaught (in promise) Error: traverseParentPath(....): Cannot traverse from and to the same ID, ``.

Caused by findDOMNode in Cell.jsx

Looks like replacing it with an element ref should fix it?
@dphaener
Copy link

@gavmck That's possible. This entire component really needs some work to be fully compliant with 15.x.x. Want to take a crack at it? I probably won't have time to look at it in depth for a few days...

@zackify
Copy link
Member

zackify commented Mar 20, 2017

This might work correctly, don't have time to pull it down tho #21

@gavmck gavmck mentioned this issue Mar 21, 2017
Merged
@gavmck
Copy link
Contributor Author

gavmck commented Mar 21, 2017

Smashed in a pull request. Few warnings on propTypes validation, but seems to be working.

@dphaener
Copy link

@gavmck 0.3.0 released. Thanks again! 🎉

@gavmck
Copy link
Contributor Author

gavmck commented Mar 21, 2017

Awesome! 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update to react 15 (and all the other packages) etchteam/scheduler
3 participants
@zackify @gavmck @dphaener