XEP-0313 MAM support. #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -49,6 +50,12 @@ Default is nil, cause MUC logging may be i/o-intensive." | |||
| :type 'boolean | |||
| :group 'jabber-history) | |||
|
|
|||
| (defcustom jabber-history-mam nil | |||
There was a problem hiding this comment.
shouldn't that be a per-account option instead?
| (nreverse jabber-mam-results)) | ||
|
|
||
| (provide 'jabber-mam) | ||
| ;;; jabber-mam.el ends here |
There was a problem hiding this comment.
Functions in these files are quite long. Your code would gain readability if some smaller functions were extracted from the large ones.
Prevent hang on error.
|
Hi, thanks for the review.
DamienCassou commented on this pull request.
+(defcustom jabber-history-mam nil
shouldn't that be a per-account option instead?
The current scope follows that of the `jabber-history-enabled' option.
Would it make sense to keep both options with the same scope in this
pull request, and possibly make the options account-specific at a later
time? I'd rather isolate the MAM implementation from other
improvements, if that makes sense.
That being said, the code would hang when MAM is enabled but not
supported by a server, so I have implemented a tentative fix for that.
Functions in these files are quite long. Your code would gain readability if some smaller functions were extracted from the large ones.
I updated the code, splitting functions into smaller components. I hope
it improves readability.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt at implementing support for XEP-0313 Message Archive Management (http://xmpp.org/extensions/xep-0313.html).
I am testing this with a prosody server (Prosody trunk nightly build 732 (2016-12-19, 8efd51667622)) and mercurial prosody-modules (https://hg.prosody.im/prosody-modules/ changeset 2462:81127dcdb326).
It would be useful if people could test this and report.