Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move publish_active to avoid race condition #302

Merged
merged 2 commits into from
May 3, 2024

Conversation

strawgate
Copy link
Collaborator

@strawgate strawgate commented May 2, 2024

Tests pass, appears to be publishing documents

@strawgate
Copy link
Collaborator Author

Fixes #301

Copy link
Contributor

github-actions bot commented May 2, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
__init__.py00100% 
elasticsearch
   __init__.py90297%208–209
   config_flow.py2522888%85, 124, 232, 314, 337, 351, 392–395, 397–398, 400, 402–404, 406–407, 421–422, 426, 466, 472, 512, 587, 596, 630–631
   const.py330100% 
   entity_details.py330100% 
   errors.py28389%51, 60, 67
   es_doc_creator.py1830100% 
   es_doc_publisher.py2601594%103, 245–246, 262–263, 366, 466–467, 469–470, 472–476
   es_gateway.py1001981%82–83, 102, 118–120, 122, 124–125, 127–131, 133–137
   es_index_manager.py123893%243–244, 261–262, 267–268, 297–298
   es_integration.py37294%43–44
   es_privilege_check.py550100% 
   es_serializer.py10190%17
   es_version.py300100% 
   logger.py20100% 
   system_info.py25196%37
   utils.py40100% 
TOTAL12657993% 

Tests Skipped Failures Errors Time
95 0 💤 0 ❌ 0 🔥 7.403s ⏱️

@strawgate
Copy link
Collaborator Author

strawgate commented May 2, 2024

@legrego I'm not actually sure how to hotfix 0.7

We probably don't want to release main, do we make a 0.7 branch from the 0.7 tag, merge this PR into that, and then cut a new release?

If so can you make a branch I can backport into?

If not please advice or feel free to steal this change and do it the right way

@strawgate strawgate enabled auto-merge (squash) May 2, 2024 20:19
@legrego legrego changed the base branch from main to v0.7.1-hotfix May 3, 2024 14:32
@legrego legrego changed the base branch from v0.7.1-hotfix to main May 3, 2024 14:33
@strawgate strawgate merged commit acbbfe7 into legrego:main May 3, 2024
3 checks passed
legrego pushed a commit that referenced this pull request May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants