fix: editor warning message hidden (microsoft#2540)

Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: Andy Brown <asbrown002@gmail.com>
lei9444 · Apr 7, 2020 · 5314430 · 5314430
1 parent 74203c6
commit 5314430
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/...s/lib/code-editor/demo/src/richEditor.tsx → ...s/lib/code-editor/demo/src/baseEditor.tsx b/...s/lib/code-editor/demo/src/richEditor.tsx → ...s/lib/code-editor/demo/src/baseEditor.tsx
@@ -3,7 +3,7 @@
 
 import React, { useState } from 'react';
 
-import { RichEditor } from '../../src';
+import { BaseEditor } from '../../src';
 
 const LU_HELP = 'https://aka.ms/lu-file-format';
 
@@ -28,7 +28,7 @@ export default function App() {
         <button onClick={() => setShowError(!showError)}>Toggle Error</button>
         <button onClick={() => setShowWarning(!showWarning)}>Toggle Warning</button>
       </div>
-      <RichEditor
+      <BaseEditor
         onChange={newVal => setValue(newVal)}
         value={value}
         placeholder={placeholder}

diff --git a/Composer/packages/lib/code-editor/src/BaseEditor.tsx b/Composer/packages/lib/code-editor/src/BaseEditor.tsx
@@ -59,7 +59,7 @@ const styles = {
       border-color: ${borderColor};
       transition: border-color 0.1s linear;
       box-sizing: border-box;
-      height: calc(${typeof height === 'string' ? height : `${height}px`} - ${error ? 32 : 0}px);
+      height: calc(${typeof height === 'string' ? height : `${height}px`} - ${error || warning ? 32 : 0}px);
     `;
   },
 };