Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various improvements. #3

Merged
merged 7 commits into from Jan 18, 2017

Conversation

fredrikt
Copy link
Contributor

Improve logging, robustness etc.

No need to fetch all attributes when only CKA_ID will be used, and
only fetch that one attribute if it will actually be used.
E.g. if the PIN is incorrect, it doesn't make sense to continue trying
until the end of gunicorns patience.
@leifj
Copy link
Contributor

leifj commented Jan 17, 2017

Failure: IndentationError (expected an indented block (pk11.py, line 128)) ... ERROR

@fredrikt
Copy link
Contributor Author

fredrikt commented Jan 17, 2017 via email

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.8%) to 89.164% when pulling 1bfb5a7 on fredrikt:ft-various_improvements into f7b0df7 on leifj:master.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 2a4a01c on fredrikt:ft-various_improvements into ** on leifj:master**.

@leifj leifj merged commit c4637a8 into IdentityPython:master Jan 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants