fix server auth key not saving #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like it works, thanks! I agree randomly generating it would be nice. The reason its not is because i currently have no way to pull this data down when deploying the game servers with ansible. Its a solvable problem, but i have not currently created a mechanism to allow for this. |
|
i am thinking only randomly generating the key on create on the server side, that way it can then be copied to ansible. like how sourcebans provides an id to be set. |
|
Yeah, that's a good default to go with 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes the server auth key from not being saved in the server creator/editor. also hopefully makes it clearer that it is an auth key not the password to join the server. better solution would be to have the key be randomly generated.