Refactor. #240
Refactor. #240
Conversation
|
A external filter is defined by a key. If no such filter exists, it throws an exception, but if a grid has no records to show, no filters should be shown and we relax this rule by NOT throwing exceptions in this case |
|
if |
|
You have changed the arity of #find_one_for from 1 to 2, but you haven't changed the method itself. There will be an error |
|
Ok I understant what means, but can you check if my refactor is fine? |
| if rendering.find_one_for(:in_html) { |column| column.detach_with_id } | ||
| grid.output_buffer.return_empty_strings_for_nonexistent_filters = true | ||
| end | ||
| rendering.find_one_for(:in_html, true) { |column| column.detach_with_id } |
There was a problem hiding this comment.
this will cause an error. Wice::GridRenderer#find_one_for has the arity of 1.
I think you want to pass true to the output_buffer, but rendering is a different object, it is not GridOutputBuffer where #filter_for is.
|
Ok I understand I rollback some changes. |
|
merged. Running my test suite |
|
Fine. 2015-07-16 11:47 GMT+02:00 Yuri Leikind notifications@github.com:
|
Hi I did my first refactor.
Can you check if fine this file?
lib/wice/helpers/wice_grid_view_helpers.rb
development...ryanfox1985:development#diff-a2fdf58bd2318a96538f29bab5343700L156
Regards