Revised configs. #245
Merged
Revised configs. #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed dependencies Rails > 3.2.
Removed extensions. Added test.
Added test.
|
i think I merged it already https://github.com/leikind/wice_grid/commits/development btw I merged a branch into 'development' which changes the API and removes some ugly old code https://github.com/leikind/wice_grid/blob/development/CHANGELOG.md#360 |
|
Hey why you don't merge mi code? |
|
Why do you push to a feature branch at all? Please don't. The branch to work on is development. |
|
I am reverting your variable renaming in wice_grid_misc.rb. I wrote this code just the other day and I have my reasons to call that variable precisely this way. It has to do with the functionality I am adding, and not the immediate data types that you are seeing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rubocop fails not affect to travis.
Removed extensions.
Added test.