New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

to_h leaves empty sorting headers in Rails 4 #318

Merged

leikind merged 2 commits into leikind:rails3 from Datyv:rails3

Aug 1, 2016

Contributor

Datyv commented Aug 1, 2016

Hey Yuri,
we're using rails 4.2.5.2. The commit from 'Philipp Großelfinger' leaves our sorting headers empty.
(http://localhost:3000/tasks?)

In our Version it just works without the .to_h method.
I hope this pull request is ok.

Greetings Yves

PS.: No Idea, why the opts[:order_direction] line is in there again.

datyv added 2 commits

August 1, 2016 10:08


          fixed empty sorting headers for rails 4

b5e74eb


          rails to Rails

cc1b54a

coveralls commented Aug 1, 2016 •

edited

Coverage decreased (-0.04%) to 37.512% when pulling cc1b54a on Datyv:rails3 into 98025f3 on leikind:rails3.

leikind merged commit fe40a50 into leikind:rails3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment