Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce discovery timeout #69

Merged
merged 2 commits into from
Apr 11, 2021
Merged

Reduce discovery timeout #69

merged 2 commits into from
Apr 11, 2021

Conversation

KapJI
Copy link
Collaborator

@KapJI KapJI commented Apr 11, 2021

I noticed in my logs and logs of other people that zeroconf discovery is actually pretty fast and all devices are discovered under 1 second.

Reducing this timeout will make google_home initial setup and component startup much faster.

Also add an option to get_google_devices to override it.

For some reason pylint was broken because it was unable to find socket symbols which are implemented in C. Fixed that as well.

And decorator==5.0.1 no longer exists: https://pypi.org/project/decorator/#history

@KapJI KapJI added the performance Performance label Apr 11, 2021
@KapJI KapJI requested a review from leikoilja April 11, 2021 08:48
@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Apr 11, 2021
@KapJI KapJI removed the dependencies Pull requests that update a dependency file label Apr 11, 2021
Copy link
Owner

@leikoilja leikoilja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's nice!
The only this is I'm afraid we might start having tons of timeout if ppl network is not tuned well... I think we can totally take that "risk" but let's keep an eye for timeouts in logs, so we accidentally don't introduce a potential problem 😅

@leikoilja
Copy link
Owner

Thank you 💥 🚀

@KapJI KapJI merged commit 3185873 into leikoilja:master Apr 11, 2021
@KapJI KapJI deleted the discovery-timeout branch April 11, 2021 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants