Add more type hints, fix some pylint warnings #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leikoilja
reviewed
Apr 11, 2021
Comment on lines
+291
to
+294
| access_token = self.get_access_token() | ||
| if not access_token: | ||
| LOGGER.debug("%s Unable to obtain access token.", log_prefix) | ||
| return None |
There was a problem hiding this comment.
I'm wondering if we should extract that check into a helper function decorator or just a helper function to call at all places as we do now
leikoilja
approved these changes
Apr 11, 2021
Comment on lines
+57
to
+59
| good-names = [ | ||
| "zc", | ||
| ] |
There was a problem hiding this comment.
To fix invalid-name pylint warning in ServiceListener methods. This allows zc as a valid name.
| @@ -279,6 +280,7 @@ def test_get_homegraph( | |||
| self.assertEqual(m_get_home_graph_request.call_count, 1) | |||
|
|
|||
| # Expired homegraph | |||
| assert self.client.homegraph_date is not None | |||
There was a problem hiding this comment.
Let's have here unittest pattern, just to have it consistent with the rest of the code?
Suggested change
| assert self.client.homegraph_date is not None | |
| self.assertIsNotNone(self.client.homegraph_date) |
There was a problem hiding this comment.
Unfortunately, mypy can't narrow type from such calls: python/mypy#4063
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mypy helps to catch places where
Optionalis not handled properly.Fixes #66