Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google home device not deleted if a device is renamed in google home #184

Open
skank01 opened this issue Apr 12, 2021 · 8 comments
Open
Labels
feature New feature or request

Comments

@skank01
Copy link

skank01 commented Apr 12, 2021

Describe the bug

After renaming a google home device in google home (the device switched room too) , the new device/entities are created by the addon, but the old ones stay present.
Even after reloading the addon....

Version of the integration

Latest version

@KapJI
Copy link
Collaborator

KapJI commented Apr 12, 2021

This is not implemented. You can remove old entities manually in HA entity manager.

@KapJI KapJI added the feature New feature or request label Apr 12, 2021
@skank01
Copy link
Author

skank01 commented Apr 12, 2021

No you cant, you can only disable it.

@KapJI
Copy link
Collaborator

KapJI commented Apr 12, 2021

You may need to restart HA first. Then it should be possible in entities registry:
Screenshot 2021-04-12 at 19 32 03

@DurgNomis-drol
Copy link
Collaborator

Will be low priority as you can delete entities in HA directly as @KapJI have said 😊 Also adding auto delete, we will risc that devices will appear and be removed and appear again and so on.

@KapJI
Copy link
Collaborator

KapJI commented Apr 13, 2021

Right now we use device_name in entity unique id. I think glocaltokens can provide some real device specific id for the device. Then HA should handle renames itself.

@DurgNomis-drol
Copy link
Collaborator

Let's create a separat feature for changing the unique id from device_name to a "Real" unique id. 😃

We can probably find a unique id from this endpoint.

@leikoilja
Copy link
Owner

We can indeed either extract something from eureka endpoint or simply generate uuid on glocaltokens side :)

@leikoilja
Copy link
Owner

Now that we use unique_id(https://github.com/leikoilja/ha-google-home/releases/tag/v1.7.0) for devices this feature should be fixed. But needs to be double-checked, before we can close the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants