Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature - Change unique id from device_name to something really unique. #199

Closed
DurgNomis-drol opened this issue Apr 13, 2021 · 8 comments · Fixed by #310
Closed

Feature - Change unique id from device_name to something really unique. #199

DurgNomis-drol opened this issue Apr 13, 2021 · 8 comments · Fixed by #310
Labels
feature New feature or request glocaltokens For fixes related with the glocaltokens dependency refactoring Refactoring

Comments

@DurgNomis-drol
Copy link
Collaborator

DurgNomis-drol commented Apr 13, 2021

We can either use this endpoint or as @leikoilja mentioned, we can generate one in glocaltokens.

What do you guys think is the best option?

Original:
Right now we use device_name in entity unique id. I think glocaltokens can provide some real device specific id for the device. Then HA should handle renames itself.

Originally posted by @KapJI in #184 (comment)

@DurgNomis-drol DurgNomis-drol added feature New feature or request refactoring Refactoring labels Apr 13, 2021
@KapJI
Copy link
Collaborator

KapJI commented Apr 13, 2021

The best option is some id from home graph. MAC address should be good as well.

@DurgNomis-drol
Copy link
Collaborator Author

DurgNomis-drol commented Apr 13, 2021

I think it would be great if we can generate one from homegraph. It will also make it possible for us to then introduce a device.compatible attribute, so the first time we actually know if the device is compatible, we don't need to check again. 😃

@leikoilja
Copy link
Owner

leikoilja commented Apr 13, 2021

That does sound nice. Let's create a follow-up ticket on glocaltokens to getting an ID and passing it over
Edit: leikoilja/glocaltokens#75

@gary-reyes
Copy link

Is there an ETA on this?

@KapJI
Copy link
Collaborator

KapJI commented Apr 27, 2021

I don't think anyone is working on this at the moment.

@leikoilja
Copy link
Owner

I'm currently traveling, but will be back home end of the week and can take a look at it, it sounds like a relatively quick fix. @gary-reyes, if interested - PRs are welcomed 💥

@ArnyminerZ ArnyminerZ added the glocaltokens For fixes related with the glocaltokens dependency label Jun 8, 2021
@skank01
Copy link

skank01 commented Jul 6, 2021

I'm seeing an error in my home assistant logbook
Platform google_home does not generate unique IDs. ID Slaapkamer Parents/device already exists - ignoring sensor.slaapkamer_parents_device

Will this get fixed with it, or is my issue a total different one?

@leikoilja
Copy link
Owner

Gents, please kindly upgrade to 1.7.0
https://github.com/leikoilja/ha-google-home/releases/tag/v1.7.0
Note, there are some breaking changes in the release notes :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request glocaltokens For fixes related with the glocaltokens dependency refactoring Refactoring
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants