Catch exceptions when getting alarms and timers to better allow for debugging #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@leikoilja @KapJI What do you guys think? |
KapJI
requested changes
Mar 22, 2021
|
Confirmed to solve the issue so far. |
|
Yay 🥳 thank you guys for taking care of it 💥🤩 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should handle these to problems and allow for us in the future to better debug if the underlaying package is throwing an exceptions when retrieving data from each device.
We need some one with problem to test it first so we can confirm that it solves the problem. I have tested it on my machine and it works.
Should close #100 and #102
More info:
The error both of them gets, is an exception thrown by, in this case,
aiohttpbecause those devices does not conform. We should just skip those devices and log them.