Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add device class for next alarm and next timer. #107

Merged

Conversation

DurgNomis-drol
Copy link
Collaborator

Should close #105

This was my fault when I first implemented next alarm and next timer sensors.

Copy link
Owner

@leikoilja leikoilja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha, don't blame yourself, not a biggie at all! Thanks for implementing the fix! 💥
Just out of curiosity, have you been able to test it on your HA setup to make sure it works? :) Would be nice to make sure it actually returns the expected result before we merge it in :)

custom_components/google_home/entity.py Outdated Show resolved Hide resolved
custom_components/google_home/entity.py Outdated Show resolved Hide resolved
@DurgNomis-drol
Copy link
Collaborator Author

@leikoilja I just tested it and it works 😄

@DurgNomis-drol DurgNomis-drol changed the title Added devices class for next alarm and next timer. Added device class for next alarm and next timer. Mar 23, 2021
@DurgNomis-drol DurgNomis-drol changed the title Added device class for next alarm and next timer. Add device class for next alarm and next timer. Mar 23, 2021
Copy link
Owner

@leikoilja leikoilja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legend! Thanks man! 💥

@leikoilja leikoilja merged commit fbb3309 into leikoilja:master Mar 23, 2021
@DurgNomis-drol DurgNomis-drol deleted the add-device-class-to-next-alarm-timer branch March 23, 2021 18:28
@leikoilja leikoilja mentioned this pull request Mar 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Next alarm/timer should be device_class timestamp
2 participants