Reduce code duplication in entities #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leikoilja
requested changes
Mar 25, 2021
|
Thanks @KapJI for taking the initiative to do this. 🚀😁 |
|
@KapJI, are you still working on it? Please re-request review when you want some of us to review :) |
leikoilja
approved these changes
Mar 25, 2021
Comment on lines
+53
to
+61
| def get_device(self): | ||
| """Return the device matched by device name | ||
| from the list of google devices in coordinator_data""" | ||
| matched_devices = [ | ||
| device | ||
| for device in self.coordinator.data | ||
| if device.name == self.device_name | ||
| ] | ||
| return matched_devices[0] if matched_devices else None |
There was a problem hiding this comment.
Love it! Thanks for implementing it. Maybe not the most looking solution, but hopefully more robust
|
I tested it locally, works as before :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify class structure.
modelwith invalidVERSIONfordevice_info. We don't really want to maintain version in different places.GoogleHomeDeviceSensorconstructor the same as for other sensors. If there is no such device incoordinator_data, set state toNone, it should render asunknownin HA.GoogleHomeAlarmSensortoGoogleHomeAlarmsSensor, same forTimers.GoogleHomeDeviceSensor.