Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix services schema and improve selectors #792

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

KapJI
Copy link
Collaborator

@KapJI KapJI commented Nov 12, 2023

  • Changing dict to vol.Schema changed behaviour of services and they lost automatic entity_id field. Bring it back.
  • type: ignore can be removed once Fix typing for entity_platform.async_register_entity_service home-assistant/core#103777 is merged and released.
  • Add selectors to filter entities from google_home integration.
  • Allow to reboot multiple devices with single google_home.reboot call.
  • Modernise code base a bit, e.g. use async_get_current_platform() and pass async functions directly to async_register_entity_service which also changes behaviour a bit and they start receiving ServiceCall.
  • Tested all services locally this time.

Fixes #786, #790

@KapJI KapJI added the bug Something isn't working label Nov 12, 2023
@KapJI KapJI requested a review from leikoilja November 12, 2023 14:40
Copy link
Owner

@leikoilja leikoilja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for fixing it! 🚀

@leikoilja leikoilja merged commit cfc069c into leikoilja:master Nov 13, 2023
5 checks passed
@KapJI KapJI deleted the fix-services branch November 13, 2023 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

reboot_device service erroring as of v1.10.1
2 participants