Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow dns query to fail when set "spray" option. #25

Merged
merged 1 commit into from
Dec 27, 2021

Conversation

yuguorui
Copy link
Contributor

When the "spray" parameter is set, dnsredir will retry indefinitely
when it encounters an error. When the network is temporarily
interrupted or misconfigured, dnsredir will eat all the CPU.

This patch fixes this issue.

Signed-off-by: yuguorui yuguorui96@gmail.com

When the "spray" parameter is set, dnsredir will retry indefinitely
when it encounters an error. When the network is temporarily
interrupted or misconfigured, dnsredir will eat all the CPU.

This patch fixes this issue.

Signed-off-by: yuguorui <yuguorui96@gmail.com>
@yuguorui
Copy link
Contributor Author

How to reproduce:

  1. Create a coredns instance with this Corefile:
.:5354 {
        dnsredir . {
                spray
                to tls://127.0.0.1 # configured as an invalid address intentionally
        }
}
  1. query the server with this cli.
nslookup -port=5354 baidu.com 127.0.0.1

@leiless
Copy link
Owner

leiless commented Dec 23, 2021

How to reproduce:

  1. Create a coredns instance with this Corefile:
.:5354 {
        dnsredir . {
                spray
                to tls://127.0.0.1 # configured as an invalid address intentionally
        }
}
  1. query the server with this cli.
nslookup -port=5354 baidu.com 127.0.0.1

Thank you! I can also reproduce this bug.

@leiless leiless merged commit e2ad429 into leiless:master Dec 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants