Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task: Update dependencies & fix deprecations #45

Merged
merged 4 commits into from
Oct 10, 2023

Conversation

jarroyoesp
Copy link
Collaborator

@jarroyoesp jarroyoesp commented Oct 10, 2023

Pull request checklist

  • I have rebased this branch on top of the destination branch (usually master)
  • I have executed locally ./gradlew spotlessApply check before creating the commit and it has run successfully
  • My contribution is fully baked and ready to be merged as is
  • I have performed a self-review of my own code
  • These changes are in compliance with the coding style of this project
  • There are no WIP commits in this PR
  • If there are changes to the UI, I have uploaded at least one screenshot of every UI change

Type of Changes

Type
🐛 Bug fix
✨ New feature
🔨 Refactoring
📜 Docs

Screenshots

Screenshot_20231010-153835

@jarroyoesp jarroyoesp marked this pull request as ready for review October 10, 2023 14:05
import androidx.compose.material.ExperimentalMaterialApi
import androidx.compose.material.ModalBottomSheetValue
import androidx.compose.material.SwipeableDefaults
import androidx.compose.material.rememberModalBottomSheetState

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reporter: Android Lint
Rule: UsingMaterialAndMaterial3Libraries
Severity: WARN
File: modules/library-ui/src/main/kotlin/com/leinardi/forlago/library/ui/component/BottomSheetNavigator.kt L21

material and material3 are separate, incompatible design system libraries Using a material import while also using the material3 library material and material3 are separate design system libraries that are incompatible with each other, as they have their own distinct theming systems. Using components from both libraries concurrently can cause issues: for example material components will not pick up the correct content color from a material3 container, and vice versa.

@@ -16,10 +16,8 @@

package com.leinardi.forlago.library.ui.component

import androidx.compose.animation.core.AnimationSpec
import androidx.compose.material.ExperimentalMaterialApi
import androidx.compose.material.ModalBottomSheetValue

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reporter: Android Lint
Rule: UsingMaterialAndMaterial3Libraries
Severity: WARN
File: modules/library-ui/src/main/kotlin/com/leinardi/forlago/library/ui/component/BottomSheetNavigator.kt L20

material and material3 are separate, incompatible design system libraries Using a material import while also using the material3 library material and material3 are separate design system libraries that are incompatible with each other, as they have their own distinct theming systems. Using components from both libraries concurrently can cause issues: for example material components will not pick up the correct content color from a material3 container, and vice versa.

@leinardi leinardi merged commit 96c4c0c into master Oct 10, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants