-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Task: Update dependencies & fix deprecations #45
Conversation
import androidx.compose.material.ExperimentalMaterialApi | ||
import androidx.compose.material.ModalBottomSheetValue | ||
import androidx.compose.material.SwipeableDefaults | ||
import androidx.compose.material.rememberModalBottomSheetState |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reporter: Android Lint
Rule: UsingMaterialAndMaterial3Libraries
Severity: WARN
File: modules/library-ui/src/main/kotlin/com/leinardi/forlago/library/ui/component/BottomSheetNavigator.kt L21
material and material3 are separate, incompatible design system libraries Using a material import while also using the material3 library material and material3 are separate design system libraries that are incompatible with each other, as they have their own distinct theming systems. Using components from both libraries concurrently can cause issues: for example material components will not pick up the correct content color from a material3 container, and vice versa.
@@ -16,10 +16,8 @@ | |||
|
|||
package com.leinardi.forlago.library.ui.component | |||
|
|||
import androidx.compose.animation.core.AnimationSpec | |||
import androidx.compose.material.ExperimentalMaterialApi | |||
import androidx.compose.material.ModalBottomSheetValue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reporter: Android Lint
Rule: UsingMaterialAndMaterial3Libraries
Severity: WARN
File: modules/library-ui/src/main/kotlin/com/leinardi/forlago/library/ui/component/BottomSheetNavigator.kt L20
material and material3 are separate, incompatible design system libraries Using a material import while also using the material3 library material and material3 are separate design system libraries that are incompatible with each other, as they have their own distinct theming systems. Using components from both libraries concurrently can cause issues: for example material components will not pick up the correct content color from a material3 container, and vice versa.
Pull request checklist
master
)./gradlew spotlessApply check
before creating the commit and it has run successfullyWIP
commits in this PRType of Changes
Screenshots